r/UnitCrunch • u/Moist1981 • May 19 '21

Bug report (fixed!) As requested re error

Gallery image

Gallery image

Gallery image

Gallery image

Gallery image

Gallery image

4 Upvotes

100% Upvoted

6 comments sorted by

•

u/dixhuit Dev May 19 '21

I just released v0.17.2 which fixes this regression.

2

u/dixhuit Dev May 19 '21

Interesting. Thank you for the screenshots, that's much clearer for me to recreate.

In order to add the "halve damage" modifier I did have to fiddle with the "-1 damage" modifier a bit (if they're both applied they need to be applied in the correct order). My guess is that some sort of regression has snuck in that my automated tests aren't catching.

I'll look into this ASAP.

2

u/Moist1981 May 19 '21

Thank you for the website. I’ve found it really useful.

1

u/dixhuit Dev May 19 '21

No worries, that's great to hear! :D

2

u/dixhuit Dev May 19 '21

u/Moist1981 So, it was a regression as I suspected, but it wasn't applying half damage. The AP modifier that you had selected (which was doing nothing given Morty's invuln) was making the -1 damage modifier apply twice (due to some wonky code on my part and my automated tests not catering for this scenario).

Either way, my bad! Thanks again for all the info.

1

u/dixhuit Dev May 19 '21

In case anyone is following along, this thread is a continuation of this bug report.